Closed rianhughes closed 3 months ago
Attention: Patch coverage is 71.50538%
with 106 lines
in your changes missing coverage. Please review.
Project coverage is 75.51%. Comparing base (
ad21b2e
) to head (f3b20cd
).
Files | Patch % | Lines |
---|---|---|
core/trie/proof.go | 67.35% | 31 Missing and 32 partials :warning: |
core/trie/trie.go | 77.85% | 16 Missing and 15 partials :warning: |
core/trie/node.go | 69.23% | 7 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@asdacap, @pnowosie in geth, the VerifyRangeProof executes the verification logic, but also logic to determine if there are more leaves to the right (see here). Imo it would be neater to separate these out into two different functions, hence why I didn't insert it in this implementation of VerifyRangeProof. What are your thoughts?
You can separate them internally if you want. But at high level, I think its easier to combine them, otherwise, need to pass the keys of proof explicitly, which is implementation details IMO.
This PR implements VerifyRangeProof.
It builds on an old PR (1873) which didn't handle empty proof keys, hence the name of this PR.
closes https://github.com/NethermindEth/juno/issues/1895 replaces / closes: https://github.com/NethermindEth/juno/pull/1873