search

Nettakrim / Signed-Paintings

14 stars 3 forks source link

Incompatibility with Enhanced Block Entities #1

Closed notabirb1 closed 1 year ago

notabirb1 commented 1 year ago

With Enhanced Block Entities installed and the option "Enhanced Signs" enabled, images don't render, and the signs show as normal. This is probably caused by the "Enhanced Signs" option using a completely different renderer than vanilla for signs, which overrides any changes by Signed Paintings.

Currently, this bug / incompatibility can be worked around by disabling "Enhanced Signs" in the EBE config menu: image

Due to the easy workaround and fairly obvious cause, this isn't really a major issue, but it may be confusing for some who don't know about it.

(P.S. This is a really cool mod, great work!)

Nettakrim commented 1 year ago

huh looking at https://github.com/search?q=repo%3AFoundationGames/EnhancedBlockEntities%20renderEnhancedSigns&type=code i dont actually see where the conflict is, i think they indirectly override the rendering so its not obvious where it gets messed with - ill investigate next week

Nettakrim commented 1 year ago

fixed in next version (1.0.2)