NetworkConfiguration / dhcpcd-ui

GTK+ / Qt / Curses interface to dhcpcd
https://roy.marples.name/projects/dhcpcd-ui
21 stars 7 forks source link

Fix possible null pointer of "tail" :lock: #2

Closed Joker2770 closed 4 years ago

rsmarples commented 4 years ago

Can you please describe how tail can be NULL here? I don't see how it's possible.

Joker2770 commented 4 years ago

Can you please describe how tail can be NULL here? I don't see how it's possible.

Assignment 'tail = NULL' at line 513, after that the 'e' possible be NULL.

rsmarples commented 4 years ago

Can you please describe how line 557 tail = e is not hit at least once or e is a NULL value there?

I can feed the function with a NULL list, a list of one element to 100 elements and it won't crash.

Joker2770 commented 4 years ago

Sorry! May be my misunderstanding.