search

NeuralEnsemble / python-neo

Neo is a package for representing electrophysiology data in Python, together with support for reading a wide range of neurophysiology file formats
http://neo.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
325 stars 248 forks source link

Make digital traces match memmap dtypes in neo. #1500

Closed h-mayorquin closed 4 months ago

h-mayorquin commented 4 months ago

@zm711

zm711 commented 4 months ago

This works for me once tests pass. You want it to be draft for more discussion on SI?

h-mayorquin commented 4 months ago

Na, man, your call as a neo mantainer. I have a slight push to got for the performance improvement but I think you are right that this might better (and is easier). We should close the spikeinterface issue once we merge this.

As an aside, I never thought that it makes sense to run a test again when you mark something from draft to ready.