search

NeuralEnsemble / python-neo

Neo is a package for representing electrophysiology data in Python, together with support for reading a wide range of neurophysiology file formats
http://neo.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
325 stars 248 forks source link

Add NeuronexusRawIO/IO #1509

Closed zm711 closed 1 month ago

zm711 commented 4 months ago

Fixes #1296.

I'll try to work on this a bit in my free time. Will switch off draft when ready for review.

Also should help for neuroconv

zm711 commented 4 months ago

No rush on this @apdavison, this is a new io. Since Sam will be going on vacation, I think getting some feedback would be nice, but I can also pester him once he is back. There is no rush on this one :)

h-mayorquin commented 3 months ago

To discuss here: expose logical streams instead of buffer streams for this format.

zm711 commented 3 months ago

It would be relatively easy. My only concern is that if we have a universal way to do this then we are adding more work to adapt all of these rawios into the new format. But in this case the last six channels are reserved for the non-ephys data. So I could split these off intro logical streams.

zm711 commented 2 months ago

Or we could merge this as is and then iterate for the logical streams in a new PR. That way if the buffer -> stream api happens before we have time then we fold that in and if this becomes an issue for users we can quickly fix it upon request before the api is added.

zm711 commented 2 months ago

@samuelgarcia, this one can also take a review in your queue. Just pinging you now that you're back here. We have a couple requests on spikeinterface (and on neuroconv) for this. At your leisure of course.

zm711 commented 2 months ago

C'est le ping à Sam de la semaine.

h-mayorquin commented 2 months ago

ceci n'est pas une ping

zm711 commented 2 months ago

He's on the thread. He'll see it :P

samuelgarcia commented 2 months ago

Salut Zach. This looks good to me. I made one or two comments. Sorry for the long delay.

zm711 commented 2 months ago

Thanks Sam. I think this is ready to go now after your feedback!

samuelgarcia commented 1 month ago

merci