search

NeuralEnsemble / python-neo

Neo is a package for representing electrophysiology data in Python, together with support for reading a wide range of neurophysiology file formats
http://neo.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
325 stars 248 forks source link

Add filename property #1571

Open PeterNSteinmetz opened 1 month ago

PeterNSteinmetz commented 1 month ago

Adds the OriginalFileName property to the NlxHeader. Also cleans up private members and moves a useful method to NlxHeader from test.

This is the last in this sequence of commits for a while now. This now provides a much clearer method of parsing the header which works with all extant files (@JuliaSprenger and thus provides that refactoring discussed a while back ;-). It should be more flexible for future possible variations and easier to modify if needed.

If one wanted to squish all of these since the divergence to master there would be much cleaner code to review, however, it would be major changes in one shot.

zm711 commented 1 month ago

Thanks Peter. Sam said he would review this when he has some time. So I assigned him to all of these and he will be the main reviewer.