search

NeuralEnsemble / python-neo

Neo is a package for representing electrophysiology data in Python, together with support for reading a wide range of neurophysiology file formats
http://neo.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
325 stars 248 forks source link

Neuronexus datetime parsing #1572

Closed h-mayorquin closed 1 month ago

h-mayorquin commented 1 month ago

Follow up on this:

3373

From this comment I did not have enough time to address there

Just a more standard way of parsing datetime strings @zm711

zm711 commented 1 month ago

Thanks Sam told me something like that existed, but he couldn't remember so he said we could merge it and that you would swoop in and save the day :)

zm711 commented 1 month ago

Interesting it says it's not isoformat?

h-mayorquin commented 1 month ago

No, that's iso format. It seems that support for reading iso datetimes was improved on python 3.11. This works just fine locally for me.

More worrisome I discovered that your test on python 3.11 are not really on python 3.11:

image

zm711 commented 1 month ago

I think we must've had a bad cache and it kept using the bad cache because it only updates if the cache is wrong in the action. I guess let me remove the cache and we can try again without the cache.

zm711 commented 1 month ago

Cache is now fixed!

zm711 commented 1 month ago

Thanks Heberto!

zm711 commented 1 month ago

And thanks for the learning experience!