Closed hexa00 closed 3 years ago
Wheter we fix this by inverting the bool or by changing the doc, I suggest that we rename the parameter as well to force users doing the update to be make them be sure that their code is ok. @vincent-antaki
Deal. I suggest we include the batch by default, as the documentation says. I kinda like the name like it is, but if we are to rename it i'd call it "keep_incomplete_batch".
I'll include the modification in PR #448 so that it's merged soon and part of 0.5.8
From the docs : https://www.neuraxle.org/stable/api/neuraxle.distributed.streaming.html?highlight=sequentialqueuedpipeline#neuraxle.distributed.streaming.BaseQueuedPipeline
The default should be not to drop the last batch, however in the code the default value for this param is False
Thus when executing:
The batch is in effect dropped