NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
48 stars 32 forks source link

Refactor dynamic table #612

Open ehennestad opened 3 weeks ago

ehennestad commented 3 weeks ago

Motivation

PR #543 (Convert Azure Pipelines to GitHub actions) contained several changes to the dynamic table interface. In order to keep a clear separation of concerns, I wanted to separate all code changes related to dynamic table refactoring into a separate (this) PR.

Checklist

ehennestad commented 3 weeks ago

@lawrence-mbf Would you mind giving a brief overview of the motivation for the changes in this PR?

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 85.83333% with 34 lines in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (6717aa1) to head (07b746d). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
+types/+util/+dynamictable/addVarargColumn.m 73.17% 22 Missing :warning:
+types/+util/getVectorClassName.m 60.86% 9 Missing :warning:
+types/+util/+dynamictable/addColumn.m 94.44% 1 Missing :warning:
+types/+util/+dynamictable/addRawData.m 92.30% 1 Missing :warning:
+types/+util/+dynamictable/getIndex.m 97.56% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #612 +/- ## ========================================== - Coverage 90.63% 90.18% -0.46% ========================================== Files 106 107 +1 Lines 4689 4767 +78 ========================================== + Hits 4250 4299 +49 - Misses 439 468 +29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.