NeurodataWithoutBorders / nwbwidgets

Explore the hierarchical structure of NWB 2.0 files and visualize data with Jupyter widgets.
https://nwb-widgets.readthedocs.io/en/latest/
Other
47 stars 22 forks source link

rmv trials from outer accordian #281

Closed bendichter closed 1 year ago

bendichter commented 1 year ago

make trials not present on the outer level of the accordion. It must be accessed through Intervals

fix #272 fix #263

https://user-images.githubusercontent.com/844306/221236025-400b3b34-13ee-45ce-96fc-f31471284ca0.mov

https://user-images.githubusercontent.com/844306/221243579-c2a06b4a-fd87-434d-aa3f-41c774c9e029.mov

codecov[bot] commented 1 year ago

Codecov Report

Merging #281 (4705b2f) into master (b228e6a) will decrease coverage by 0.01%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   66.17%   66.16%   -0.01%     
==========================================
  Files          35       35              
  Lines        3441     3443       +2     
==========================================
+ Hits         2277     2278       +1     
- Misses       1164     1165       +1     
Flag Coverage Δ
unittests 66.16% <66.66%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/panel.py 77.48% <ø> (ø)
nwbwidgets/file.py 70.21% <50.00%> (-0.90%) :arrow_down:
nwbwidgets/utils/dandi.py 95.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

CodyCBakerPhD commented 1 year ago

Wonderful, I confirmed that both fixes work!

Thanks a lot @bendichter!