Fix `channel_conversion` use in `TimeSeries.get_data_in_units`

rohanshah commented 5 months ago

Motivation

Fixes issue discussed here: https://github.com/NeurodataWithoutBorders/helpdesk/discussions/83

How to test the behavior?

Updated unit test to reflect functional change

Checklist

[x] Did you update CHANGELOG.md with your changes?
[x] Have you checked our Contributing document?
[x] Have you ensured the PR clearly describes the problem and the solution?
[x] Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
[x] Have you checked to ensure that there aren't other open Pull Requests for the same change?
[x] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

rohanshah commented 5 months ago

thanks @bendichter ! no rush on my end but what's the best way to have this merged and into the next release?

bendichter commented 5 months ago

@rohanshah I'm running tests now. If/when those pass, it'll automatically be merged to dev and will be incorporated in the next release

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.88%. Comparing base (90e6048) to head (be5c08c). Report is 21 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1923 +/- ## ======================================= Coverage 91.88% 91.88% ======================================= Files 27 27 Lines 2651 2651 Branches 692 692 ======================================= Hits 2436 2436 Misses 142 142 Partials 73 73 ``` | [Flag](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1923/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1923/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | `72.80% <0.00%> (ø)` | | | [unit](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1923/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | `83.96% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rly commented 5 months ago

Thanks for the bug fix @rohanshah !

NeurodataWithoutBorders / pynwb