NeurodataWithoutBorders / pynwb

A Python API for working with Neurodata stored in the NWB Format
https://pynwb.readthedocs.io
Other
178 stars 84 forks source link

Expose cache_spec option in NWBHDF5IO.export #1959

Closed rly closed 2 months ago

rly commented 2 months ago

Motivation

Right now, NWBHDF5IO.export always caches the spec. The option to change that is not exposed. This PR exposes that keyword argument. Ref: https://github.com/hdmf-dev/hdmf/issues/1187

Checklist

rly commented 2 months ago

I don't think tests are necessary for this quick change, but I could write one if you think we should have it @stephprince

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.20%. Comparing base (71ef8e2) to head (124332d). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1959 +/- ## ======================================= Coverage 92.20% 92.20% ======================================= Files 27 27 Lines 2656 2656 Branches 693 693 ======================================= Hits 2449 2449 Misses 134 134 Partials 73 73 ``` | [Flag](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1959/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | `73.19% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | `83.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.