Open Mateo9569 opened 1 year ago
Thinking about this...
Thautil is likely because the pscis crossing is pinned to the wrong stream? Can we point to the modelled_crossing_id
vs the stream_crossing_id
in the fpr::fpr_table_bcfp
function col
param input and use that to build the report table in the memo?
Nanika and Lamprey may be either to because of the above or because they are not picked up as being large enough to have spawn/rear habitat? A filter of the bcfishpass
object using their stream_crossing_id
and the appropriate modelled_crossing_id
should give insight
thautil not modelled as wide enough and too steep (comparing steamline characteristics to bcfishpass params documented in the methods section) to be spawn rear hab for salmon according to params used
Our data might contradict the modelling so that is something to note in the memo.
Also, there can be some modelling data (as indicated by the colored streamlines) so tying the col
param on fpr::fpr_table_bcfp
should work for the table. Of note, when we are up and ripping off DB builds with bcfishpass our inputs should change the streamline characteristics and potentially model_rear_spawn true/false results because the channel width script pulls in PSCIS(and FISS site actually) channel width data from bc data catalougue downloads of those layers to model channel width.
When we do the next run on bcfishpass Thautil will of course pin to the correct stream due the changes uploaded to https://github.com/smnorris/bcfishpass/blob/main/data/pscis_modelledcrossings_streams_xref.csv and we will not need col
param linked to the modelled_crossing_id
to alilgn the actual modelling outputs to the correct pscis crossing (ie. near 6km worth of steelhead network stream vs 0.7)
This is what I got when I pointed to the correct thautil crossing modelled_crosing_id
And this is what I got when I looked up rearing km for those three sites. Note that when getting habitat gain estimates we use co_rearing_km
in this repo.
*note - the repo sqlite database is a spring 2022 snapshot of a bcfishpass
output using channel width params (as per methods in the report). The screenshot of QGIS is a streamline set linked to a remote database spun up in the last month (April 2023), is served by Simon and used the parameters from the wcrp_parameters
fork of the repo. Although it appears channel width was used (cw) the thesholds used ( https://github.com/smnorris/bcfishpass/blob/wcrp_parameters/data/parameters_habitat_method.csv ) may be different from what we used at the time we built our last version of our sqlite
. The bcfishpass
repo evolves like a mongoose family who's house is soaked in radioactive waste so there are lots of reasons for differing outputs from one release to the next (lately they are tagged which is sweet https://github.com/smnorris/bcfishpass/tags )
Will review repo and scripts to investigate issue and post updates here.