search

NewGraphEnvironment / fish_passage_skeena_2021_reporting

https://newgraphenvironment.github.io/fish_passage_skeena_2021_reporting/
Creative Commons Zero v1.0 Universal
0 stars 2 forks source link

deal with weird min elevations for watershed stats #4

Closed NewGraphEnvironment closed 1 year ago

NewGraphEnvironment commented 2 years ago

documented hand bomb prob the best approach at this point

Mateo9569 commented 1 year ago

There are still a few weird min elevations. An example being trib to Nanika River, where the min elevation -1114. Would it be best to do what we did in skeena 2022 and just filter it out? There's an open issue about it over there.

NewGraphEnvironment commented 1 year ago

would be better to do it like this in tables.R if it doesn't break anything. Be sure to test

https://github.com/NewGraphEnvironment/fpr/issues/31

Important to review the text of the memos to make sure we don't reference the min number when it doesn't make sense (usually doesn't). Better to talk about elevation of site

Mateo9569 commented 1 year ago

Ya that did the trick, fixed it. Looks like nanika and mcbride were the only weird ones. The column elev_min is still in the site memos though, just shows up blank now. I could take the column out if you want.