search

NewOldMax / react-form-validator-core

Core validator component for react forms
MIT License
94 stars 44 forks source link

Package is not published pre-compiled #14

Closed AbiriAmir closed 6 years ago

AbiriAmir commented 6 years ago

This package is not published pre-compiled. So create-react-app can not build this package with this error:

Failed to minify the code from this file

Please refer to this link: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify

Thank you

NewOldMax commented 6 years ago

You have this issue because of webpack which uses uglify-js to build, but this package has react-lifecycles-compat@3.0.0 dependency and it has some unminified es6 code so uglify-js throws error. As I see they already fixed that, so I will update this dep this week and build should be ok

ulisesbocchio commented 6 years ago

I'd appreciate the fix too... at least a ^ on the dependency

NewOldMax commented 6 years ago

Should be fixed in 0.4.4