search

NewOldMax / react-form-validator-core

Core validator component for react forms
MIT License
94 stars 44 forks source link

ValidatorForm should probably have the `noValidate` prop by default #15

Closed bboure closed 6 years ago

bboure commented 6 years ago

Hi, I am playing a bit with the validators and so far it looks great. I just came across this little issue:

image

I used a <TextValidator> component (from react-material-ui-form-validator) with type="email" and I got the browser's validator kicking.

Solution was to add noValidate to <ValidatorForm> but since this library is all about doing custom validation, I guess it should probably come by default here?

What do you think?

NewOldMax commented 6 years ago

It's not bad to have ability to use native validation if someone wants it. Otherwise it will take some coding to enable it, if we put noValidate as default