search

NextDroid / potree

WebGL point cloud viewer for large datasets
http://potree.org
Other
1 stars 0 forks source link

Clean up: AnimationEngine #242

Closed nmhaddadND closed 4 years ago

nmhaddadND commented 4 years ago

This PR fixes an issue with animationEngine global variables. These are now replaced by local variables. It also removes old files we have not yet removed. This includes files that were renamed, or combined, including controlPointsLoader.js and remLoader.js (controlPointLoader.js handles rem data now). It also includes general cleanup (const vs let, etc.).

bcasselsND commented 4 years ago

The thing you say you are doing, "Remove animationEngine global, reduce to local scope", is not what your changes do. You must not realize that global variable animationEngine and window.animationEngine are the same thing.

So think about what you want to do here, and make the description match the effective change. Then we can talk about whether it is in a good direction or not.

nmhaddadND commented 4 years ago

This is a bad attempt. Closing as work should just be completely redone.