search

Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
916 stars 135 forks source link

Some extensions not included in extensions_1_4.json (not installable in Vortex 1.4+) #8624

Open agc93 opened 3 years ago

agc93 commented 3 years ago

Describe the bug I updated several of my extensions a couple of days ago to change its compatibility to ^1.3.0 (as I did with a few other extensions), but for some reason Modwatch and Beat Saber Support specifically aren't appearing in extensions_1_4.json and so are not installable for 1.4+ users.

To Reproduce Steps to reproduce the behavior:

  1. Go to extensions_1_4.json
  2. Look for "Beat Saber Support" or "Modwatch for Vortex"

Expected behavior They should be included in the 1_4 file since 1.4 should satisfy a constraint of ^1.3.0

Platform (please complete the following information):

Additional context Confusingly, those extensions are in the 1_3.json file and with the correct "vortex": "^ 1.3.0" dependency that should also qualify for 1_4.json

TanninOne commented 3 years ago

The reason is that our updater-tool has a memory so if an extension gets rejected or is marked as incompatible it doesn't get re-evaluated every time we update the list. In your case your extensions were previously tagged as incompatible with Vortex 1.4 and the tool then simply doesn't consider that file any more until a new version is uploaded. Part of this is that we don't differentiate between whether we rejected an extension (e.g. because it didn't install correctly) or whether the extension "rejected itself" with a version requirement.

I will fix this for now by manually resetting your extensions but I'll leave this open to remind me that the tool needs to be improved.

agc93 commented 3 years ago

Just a heads up (in case necessary) that I've just added another constraint to an existing file: v0.0.5 of the Project Wingman extension now has a ~1.3.0 constraint (to separate it from the new 1.4+ v0.1.0).

Hopefully that doesn't also break much. I'll try and stick to new files for future stuff, but this one was already in-flight.

TanninOne commented 3 years ago

That seems to have worked correctly, extensions_1_3.json still contains the 0.0.5 file, extensions_1_4.json contains version 0.1.0.