Lots of Cover mocks still contain products, productTypes and similar leftovers which should have been removed.
StakingProducts and StakingPool have a Cover mock containing the allocateCapacity function. The function is called from the tests so it will call the StakingPool which is quite redundant as it could have been called from the tests directly impersonating the cover contract address.
The CPMockCover should implement the legacy cover contract for the migration tests, setProductsAndProductTypes should not be present on an actual cover contract mock. Technically this test is short lived, so maybe we can remove the test and its leftover functions entirely after the upgrade.
There could be more issues, these are just some of them.
products,productTypesand similar leftovers which should have been removed.StakingProductsandStakingPoolhave aCovermock containing theallocateCapacityfunction. The function is called from the tests so it will call theStakingPoolwhich is quite redundant as it could have been called from the tests directly impersonating the cover contract address.CPMockCovershould implement the legacy cover contract for the migration tests,setProductsAndProductTypesshould not be present on an actual cover contract mock. Technically this test is short lived, so maybe we can remove the test and its leftover functions entirely after the upgrade.