search

NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
23.37k stars 2.71k forks source link

Add support for proxy_protocol in proxy_hosts and streams #4105

Open snordmann opened 1 month ago

snordmann commented 1 month ago

Closes #1114 Related To #1882 Related To #3537 Related To #3618

nginxproxymanagerci[bot] commented 1 month ago

Docker Image for build 4 is available on DockerHub as nginxproxymanager/nginx-proxy-manager-dev:pr-4105

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes Note: this is a different docker image namespace than the official image

snordmann commented 4 weeks ago

@jc21 What does the requires-verification label mean? Is it that somebody should test this version manually by setting their tag to nginxproxymanager/nginx-proxy-manager-dev:pr-4105?

If so I am currently running this image an tested a few of the functions (both streams and proxy hosts work with and without the proxy procotol. Editing existing proxy_host and streams works (something that does need automated tests, because I only noticed my incomplete implementation when testing manually, not in the cypress tests/CI - but that is for another time).

Anyway, you probably shouldn't rely on my word alone, so maybe somebody else could verify my changes :)