search

NiLuJe / FBInk

FrameBuffer eInker, a small tool & library to print text & images to an eInk Linux framebuffer
https://www.mobileread.com/forums/showthread.php?t=299110
GNU General Public License v3.0
328 stars 23 forks source link

The future of button_scan #8

Closed shermp closed 6 years ago

shermp commented 6 years ago

Have you given any thought as to how you would like to proceed with the button scanner? Keep it with FBInk? Spin it off to it's own project? Turn it into a library?

I'm sure I'm not the only person who would find it useful.

NiLuJe commented 6 years ago

It's designed to be pretty easy to bake into FBInk and expose as a public API (I basically just have to tweak the signature, hide it it behind a few ifdefs to make it throw -ENOSYS on !KOBO), and that's probably the easiest way to go forward, because it kind of does rely on half of FBInk's private API ^^, so the only sane way to spin it off would be turning it into a binary (i.e., exactly as it currently stands). Which would, arguably, be less useful/interesting ;).

The only question left is how much special-casing it's going to need to handle the various quirks needed to suport touch input everywhere... (And that's just annoying in the "I don't have the HW to test it myself" way, the implementation details once we know what to do where are pretty straightforward: I just add as many new fields as necessary in the deviceQuirks struct ;D).

shermp commented 6 years ago

Sounds good. Baking it into FBInk does seem like the easiest solution, even if it doesn't quite fit the "print crap to the screen" theme that FBInk has.

As for testing, you may want to appeal to some kind souls (cough victims) on Mobileread to help test it when ready.

NiLuJe commented 6 years ago

Yeah, I'm thinking of handling the "doesn"t quite fit" issue by isolating the implementation in a dedicated source file, and possibly keeping the standalone CLI front-end instead of accessing it via yet another flag in the fbink CLI tool...

NiLuJe commented 6 years ago

Done in master :).

shermp commented 6 years ago

Awesome. I shall give it a go, Thank you very much.

shermp commented 6 years ago

It works! (On my H2O at least...)

I shall wait until the next FBInk release, or until things are stable before merging my wrapper updates into master.

NiLuJe commented 6 years ago

Glad to have confirmation I didn't break anything in the process ^^.

I think I'm mostly done with the rest of what I had in mind for 1.3.0, but I'll let it simmer for a few days before tagging it ;).

On Sat, Aug 4, 2018, 05:48 Sherman Perry notifications@github.com wrote:

It works! (On my H2O at least...)

I shall wait until the next FBInk release, or until things are stable before merging my wrapper updates into master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NiLuJe/FBInk/issues/8#issuecomment-410420823, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG1ZsFAKxXdj-H_s7BQ1fykzNYe8HsPks5uNRmSgaJpZM4VtGN4 .