NiXium-org / NiXium

Open-Source Infrastructure as Code Management Solution for Multiple Systems designed to be reliable in mission-critical tasks on paranoid and high-security environment.
European Union Public License 1.2
25 stars 3 forks source link

In-Code Tracking for GitHub Bugs #75

Open Kreyren opened 5 months ago

Kreyren commented 5 months ago

Implement a function that will check GitHub API for the state of the issue and warns the deployment manager about the issue being closed.

We use a lot of code that's like:

{ pkgs, ... }:

let
    # Wayland fix https://github.com/NixOS/nixpkgs/issues/292700#issuecomment-1974953531
    flameshotGrim = pkgs.flameshot.overrideAttrs (oldAttrs: {
        src = pkgs.fetchFromGitHub {
            owner = "flameshot-org";
            repo = "flameshot";
            rev = "3d21e4967b68e9ce80fb2238857aa1bf12c7b905";
            sha256 = "sha256-OLRtF/yjHDN+sIbgilBZ6sBZ3FO6K533kFC1L2peugc=";
        };
        cmakeFlags = [
            "-DUSE_WAYLAND_CLIPBOARD=1"
            "-DUSE_WAYLAND_GRIM=1"
        ];
        buildInputs = oldAttrs.buildInputs ++ [ pkgs.libsForQt5.kguiaddons ];
    });
in {
    services.flameshot = {
        package = flameshotGrim;
    };
}

In a hypothetical scenario where https://github.com/NixOS/nixpkgs/issues/292700 would be fixed then applying this patch has an increased risk of causing issues -> If we make a handling for this that would output a warning then we could improve the reliability of the deployment by catching unneeded workarounds early.