NicholasT1 / pe

0 stars 0 forks source link

Duplicate Detection limitations not made clear #5

Open NicholasT1 opened 1 week ago

NicholasT1 commented 1 week ago

Steps to Reproduce: add -n Bernice Yu -p 87438807 -e berniceyu@example.com -rs Mother followed by add -n bernice yu -p 87438807 -e berniceyu@example.com -rs Mother

Expected: Second person bernice yu will not be flagged as a duplicate

Rationale: Since names are normally case-insensitive in real life, bernice yu and Bernice Yu are likely to be duplicates of one another to the user, since all other fields are the same. As such, limitations of the duplicate detection should be made clearer so that the user does not have the false impression that these duplicates are being handled by the app. Screenshot 2024-11-15 163551.png

soc-se-bot commented 4 days ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names with different caps but same details can be added.

Steps to reproduce:

  • add a person "misty" with the contact details shown in the screenshot
  • add another person "Misty" (same name but with different caps) with the same contact details in the screenshot.

Both "misty" and "Misty" are likely to be the same person, it could be user typo in this case. The user guide didn't mention that names are case-sensitive or case-insensitive. Maybe letting names to be case-insensitive and checking all the other details could fix this problem.

image.png


[original: nus-cs2103-AY2425S1/pe-interim#2342] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is an intended feature of the application.

Just as how the 'Contacts' app on your Android/iPhone allows two people with the exact same name but with different capitalisations or a one character difference in their phone number, our application allows users the freedom to name the fields whatever they want.

We only reject duplicates if there is an exact match in all of the fields.

However, this could be a potential improvement for the future, where we add better duplicate detection based on the needs of the target user group.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The 'original' bug here is pointing out a feature flaw in duplicate detection, whereas I am pointing out that the documentation should be improved so that users are not confused by the duplicate detection.


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** A documentation bug that should be trivial to add in/fix.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** Duplicate detection limitations should be made clearer in the documentation rather than there being a problem with the feature.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]