Nik-Potokar / XIVSlothCombo

XivCombo for very lazy gamers
GNU General Public License v3.0
255 stars 307 forks source link

[AST] Quick Target Cards causes FPS drop on AST #1236

Closed Rueby closed 1 year ago

Rueby commented 1 year ago

This was never an issue in prior to 6.4, disabling the plugin essentially returns everything to a stable fps across all jobs (accounting for the fps hit from other plugins).

Example with plugin enabled [ooc] DRG (and mostly other jobs too) 77-80 fps AST 44-47 fps

With plugin turned off All jobs around 85 fps (including astro)

Any ideas?

Edit : Narrowed it down to Quick Target Cards. I never had an issue with that dropping my fps before.

Taurenkey commented 1 year ago

I need more details as to when this happening.

k-kz commented 1 year ago

We've struggled to replicate this on our end so far, but have enough mentions/reports of it to know it's not a user-end thing. We'll look into it as soon as we find a good way to replicate

Rueby commented 1 year ago

It happens whenever I switch to AST and have Quick Target Cards enabled, I don't have to do anything else, just being on the job tanks my fps. it happens in every location I went to. I tried going to really low population areas like the Tempest but no luck. Casting down below is drawing cards, ogcds.

Upper Limsa AST w/o Quick Target Cards : 102FPS Stationary, 84-92FPS casting/in motion AST w/ Quick Target Card : 42FPS Stationary, 28-31FPS casting/in motion

The Tempest (Macareneses Angle) AST w/o Quick Target Cards : 152-141FPS Stationary, 131-136FPS casting/in motion AST w/ Quick Target Card : 57FPS Stationary, 43-45FPS casting/in motion

What else can I provide to help?

Taurenkey commented 1 year ago

We would really need a list of your other plugins if you don’t mind sharing. It’s very likely a conflict somewhere.

Rueby commented 1 year ago

I don't mind sharing at all if it helps! I'm not sure how I can provide you with a list of my loaded plugins so I just copied and pasted what popped when the game loaded for me. If it helps at all, I tried to troubleshoot before using a 50/50 method on an empty installedPlugins folder to try and find if I could find anything specific but I think that's just beyond me.

Edit : This list was from this morning.

》 Accountant v1.3.5.1 loaded. 》 Adventurer in Need v1.3.0.2 loaded. 》 AFK Patcher v1.0.0.1 loaded. 》 Artisan v1.8.0.2 loaded. 》 Astro v2.0.0.6 loaded. 》 Audible Character Status v1.0.1.3 loaded. 》 AutoRetainer v3.1.3.0 loaded. 》 Beachcomber v1.2.1.2 loaded. 》 Better borderless window mode v0.0.0.1 loaded. 》 Better Shadows v1.1.5.0 loaded. 》 Better Targeting System v0.0.7.0 loaded. 》 BigPlayerDebuffs v1.1.0.8 loaded. 》 Blue Mage Helper v2.0.6.0 loaded. 》 Boss Mod v0.0.0.96 loaded. 》 Brio v0.1.8.6 loaded. 》 Character Panel Refined v1.7.1.5 loaded. 》 Chat Bubbles v2.1.4.0 loaded. 》 Clarity In Chaos v1.2.0.1 loaded. 》 Compass v1.26.3 loaded. 》 Customize+ v0.0.1.8 loaded. 》 Damage Info v2.3.0.2 loaded. 》 Death Recap v1.10.2.1 loaded. 》 Doze Anywhere v0.2.1.2 loaded. 》 EasyEyes v1.2.2.2 loaded. 》 EnemyListDebuffs v0.3.8.0 loaded. 》 ezFauxHollows v1.2.0.0 loaded. 》 ezMiniCactpot v1.2.0.0 loaded. 》 ezWondrousTails v2.2.0.3 loaded. 》 FF Logs Viewer v2.1.2.4 loaded. 》 FPS Plugin v1.6.0.5 loaded. 》 Fungah v1.0.0.0 loaded. 》 GatherBuddy v3.2.4.2 loaded. 》 GCDTracker v1.0.2.7 loaded. 》 Glamaholic v1.9.12.0 loaded. 》 Glamourer v0.1.2.1 loaded. 》 HaselTweaks v14.11.3 loaded. 》 Heels Plugin v1.3.4 loaded. 》 Heliosphere v1.13.0.0 loaded. 》 High FPS Physics Fix v7.2.0.0 loaded. 》 Honorific v1.0.1.2 loaded. 》 Housing Timeout Reminder v1.0.2.0 loaded. 》 Hunt Buddy v1.0.1.0 loaded. 》 Hunt Helper v1.0.0.5 loaded. 》 Hunty v1.1.0.0 loaded. 》 Immersive Flavor Text v0.3.0.1 loaded. 》 Inventory Search Bar v1.3.0.0 loaded. 》 Inviter v1.1.1.0 loaded. 》 Item Search v1.9.3.1 loaded. 》 Item Vendor Location v2.2.0.2 loaded. 》 JobBars v1.2.3.6 loaded. 》 LazyLoot v5.1.0.1 loaded. 》 Lifestream v1.0.0.5 loaded. 》 LogChamp v1.0.1.1 loaded. 》 MapLinker v1.1.7.3 loaded. 》 Mare Synchronos v0.8.44 loaded. 》 Market board v1.2.0.0 loaded. 》 Marketbuddy v0.2.2.16 loaded. 》 Monster Loot Hunter v1.0.17.4 loaded. 》 Mouseover Action v4.2.14.0 loaded. 》 Nameplate Debuffs v1.0.2.0 loaded. 》 NoSoliciting v3.0.6 loaded. 》 NotificationMaster v2.1.0.8 loaded. 》 Ocean Fishin' v2.4.0.0 loaded. 》 Orange Guidance Tomestone v1.7.1.0 loaded. 》 Orchestrion Plugin v2.0.0.2 loaded. 》 Palace Pal v4.8.0.2 loaded. 》 Palette+ v0.3.9 loaded. 》 Pandora's Box v1.1.1.1 loaded. 》 Peeping Tom v1.7.14 loaded. 》 Penny Pincher v1.6.0.1 loaded. 》 Penumbra v0.7.1.4 loaded. 》 PingPlugin v2.5.2.0 loaded. 》 Pixel Perfect v3.0.3.0 loaded. 》 PlayerTrack v2.8.1.0 loaded. 》 Price Insight v2.5.0.1 loaded. 》 QoL Bar v2.3.2.1 loaded. 》 QuestAWAY v2.0.0.1 loaded. 》 ReAction v1.3.3.5 loaded. 》 Ready Check Helper v1.0.4.3 loaded. 》 Redirect v1.2.1.5 loaded. 》 RepairMe v1.0.1.14 loaded. 》 Saucy v1.2.0.0 loaded. 》 Say What? v1.0.2.1 loaded. 》 SelfCare v0.1.0.0 loaded. 》 Simple Tweaks Plugin v1.8.7.2 loaded. 》 SkillSwap v1.2.2.1 loaded. 》 Sound Filter v1.4.10.0 loaded. 》 Splatoon v3.2.1.5 loaded. 》 StackSellPrice v4.1.1 loaded. 》 Submarine Tracker v1.5.1.3 loaded. 》 Target Lines v1.2.3.0 loaded. 》 Teleporter v2.0.2.1 loaded. 》 TextAdvance v3.0.0.7 loaded. 》 The Great Separator v1.2.6.0 loaded. 》 Tidy Chat v1.2.4.0 loaded. 》 Title Edit v2.2.6.12 loaded. 》 Tourist v1.2.12 loaded. 》 TPie v1.7.0.0 loaded. 》 TriadBuddy v1.8.0.2 loaded. 》 VFXEditor v1.7.5.2 loaded. 》 Visibility v1.1.4.10 loaded. 》 Waymark Preset Plugin v1.4.6.0 loaded. 》 Weatherman v2.4.0.8 loaded. 》 Where's my mouse v0.0.0.6 loaded. 》 Which Patch Was That? v1.4.0.0 loaded. 》 World Map Enhancer v1.0.1.0 loaded. 》 XIV Instant Messenger v1.2.1.0 loaded. 》 XIVSlothCombo v3.0.18.3 loaded. 》 Yes Already v1.3.0.2 loaded. 》 ZodiacBuddy v0.1.0.4 loaded.

k-kz commented 1 year ago

@Taurenkey "better targeting system" jumping out at me here, no idea what it is though.

Edit: oh, and Astro, of course.

Rueby commented 1 year ago

Better Targetting System by Lynesth is on the official dalamud repo, this. ![Uploading image.png…]()

Is there anything you'd like more info on? I tried disabling that and still had the same fps issue.

k-kz commented 1 year ago

Should be good for now, @Taurenkey will let you know if there's anything else - we're just trying to pick out potential conflicts with other plugins that directly affect the targeting system in any way. Thanks for your responses so far!

Taurenkey commented 1 year ago

The biggest stand-outs to me are Astro (since that is trying to do the same thing), Redirect, ReAction, Boss Mod, Mouseover Action and Better Targeting System.

Of all of these, I'd say turn off Astro & Boss Mod, then if that doesn't resolve, the rest of them. However I do note you have a lot of plugins being loaded, which probably doesn't help either.

Rueby commented 1 year ago

Right, I first disabled Astro and Boss Mod, nothing happened FPS was around 40-42 stationary I disabled all the plugins you had listed with really negligible FPS gains around 2-3 FPS

You're right, I do have many plugins which made trying to find this a nightmare since nothing really stood out when I did a 50/50 split to try and see if it's a specific plugin. I came to kinda accept that having plugins active will have a negative impact on FPS so it made finding this difficult since I thought it was a penumbra mod that broke, bots underground, my gpu dying (or overheating) and it wasn't until I started disabled this plugin that my fps jumped back up hence my post

Does it help at all to mention that having Astro enabled doesn't cause any performance issues? I remember using this option before even knowing about Astro and everything was fine (iirc, it was a long time ago) because I remember how happy I was not having to deal with the cards 😂

Taurenkey commented 1 year ago

Can you try having Sloth as the only plugin running and see if it does it still?

Rueby commented 1 year ago

Right, I am trying it out currently with Sloth and FPS plugin are the only two things enabled to check. Location of testing is a housing area in Shiro

Quick Target Cards Disabled & FPS unlocked [Stationary] Around 177-180 FPS [In motion] Around 167-180 FPS

Quick Target Cards Enabled & FPS unlocked [Stationary] Around 125-130 FPS [In Motion/Combat] Around 116-120 FPS

So around maybe 50-60 FPS loss just from that option enabled? Edit : Which is pretty consistent with the fps loss I usually take having all plugins enabled, it's always around a 50-60 fps hit just from that option.

Taurenkey commented 1 year ago

And does having /xllog open show anything?

Rueby commented 1 year ago

What should I be looking for? There's a bunch of [PLUGINR] successfully fetching repositories. Other than that nothing aside from me disabling FPS plugin because I was rechecking if anything differs (nothing differs)

Taurenkey commented 1 year ago

I was just curious if it was spamming errors for whatever reason.

Rueby commented 1 year ago

It doesn't seem to be the case. The only things I'm seeing is a repo trying to replace a plugin that's already in the official repo...nothing related to this repository though.

Edit: I've been running around and having the console open while spamming ogcds, the only thing I'm seeing is a debug message that says "[XIVSlothCombo] Changing Target" on draw and another time on play. No errors whatsoever.

k-kz commented 1 year ago

@Rueby closed this for now having merged #1243, please reopen if the issue persists. Thanks!

Rueby commented 1 year ago

The issue still remains even after the merge.

k-kz commented 1 year ago

The issue still remains even after the merge.

Are you actually building locally or are you using the release version? If the latter, we haven't pushed the update out yet. It'll be in v3.0.18.4

Taurenkey commented 1 year ago

Going to re-open this until we actually launch the update and get verification.

Rueby commented 1 year ago

oh I thought it was pushed already my bad! I'm using the release version 😓

k-kz commented 1 year ago

@Rueby the v3.0.18.4 update containing the potential fix has been released now - please let us know if anything changes and/or the issue persists. Leaving this open 'til we get further confirmation.

Clueless-AI commented 1 year ago

Hello, I've been having this issue for a month now and never thought of opening an issue here till this morning and luckily a fix was pushed :D After a lot of testing I realized that the FPS drops were happening only (99% of times) in dungeons where there only 4 people and If I have a card running on a melee or a caster for example and I draw a card which should go to the same Role then the plugin kinda struggle to find who to give it to or something then the FPS start dropping. This morning I tried to replicate that again but apparently the update fixed it and there's no more FPS drops. Thank you

Rueby commented 1 year ago

This update fixed it yes! Thank you, sorry for the late response!