Nikaple / nest-typed-config

Intuitive, type-safe configuration module for Nest framework ✨
MIT License
207 stars 25 forks source link

feature: implemented ability to set default values for file loaders, … #479

Closed vsamofal closed 1 year ago

vsamofal commented 1 year ago

…with dotenv-expand syntax

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Other information

vsamofal commented 1 year ago

@Nikaple Hi, one more thing regarding default values. I'm planning to update the docs a bit over the weekend, and I think that will be fine.

I have one more feature in mind but it will be for a bit later.

Right now, we make the resolution and, after that, do merge, but ideally, we should do merge first and then resolution it will be more accurate behavior, and performance will also be better, for my use cases at least.

I'm implementing a kind of PROFILES in spring

vsamofal commented 1 year ago

@Nikaple Hi, any concerns merging this?

Nikaple commented 1 year ago

Certainly, I find the code to be fine. As per our previous conversation, you mentioned your intention to make some adjustments to the documentation during the weekend. I am still waiting for the updated version 😆

vsamofal commented 1 year ago

Hi @Nikaple , docs updated

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: