search

Nitrokey / libnitrokey

Communicate with Nitrokey devices in a clean and easy manner
https://nitrokey.com/
GNU Lesser General Public License v3.0
65 stars 34 forks source link

Few meson fixes and improvements #128

Closed ignatenkobrain closed 6 years ago

szszszsz commented 6 years ago

Tested (with bundled Catch) and merged, thank you! Only an integration with CI is left and it should be complete. If you see anything to add, please let me know!

ignatenkobrain commented 6 years ago

@szszszsz would you like to drop cmake/qt stuff and just go with meson or...? I'm just not sure how to get CI for both :P

Also if this is the direction, I can port nitrokey-app to meson and then it should be working quite well.

szszszsz commented 6 years ago

That easy :-) Just adding the flag in one of the matrix entries, and then in script section recognize the flag and execute proper behavior, similarly to current Qt/CMake selector on Nitrokey App. Instructions could be in a separate script for easier testing / local build automation as well (on my todo list). Regarding the builders, I use currently Qt for making final builds for AppImage/macOS/Windows, and CMake for the development, as it is supported natively by the IDE's. I do not know how the latter looks like for Mesos yet, so for now let's settle for an 'extra builder' status for it. From brief look I like its features, so it could find easily its place in advanced testing, e.g. when building with sanitizers (in CMake I have to add it by hand).

szszszsz commented 6 years ago

If Meson allows easier work for you, e.g. in packagement or other system integration, I would happily merge it to both projects and maintain up to my skills (I know only its basics).

ignatenkobrain commented 6 years ago

cc @nirbheek @jpakkane