Nitrokey / libnitrokey

Communicate with Nitrokey devices in a clean and easy manner
https://nitrokey.com/
GNU Lesser General Public License v3.0
65 stars 34 forks source link

Change counter to 64bit unsigned Integer for NK Storage #153

Closed NKelias closed 5 years ago

NKelias commented 5 years ago

https://github.com/Nitrokey/libnitrokey/blob/9d4911d02e9e87ebd3b2a36acce4a347a58e9fff/NitrokeyManager.cc#L536-L537

NK Storage expects and returns the OTP counter value as a 64 Bit unsigned Integer from v0.54 onwards

https://github.com/Nitrokey/nitrokey-storage-firmware/pull/85

szszszsz commented 5 years ago

Is it expecting little-endian, or a conversion to big-endian is required on the library side?

NKelias commented 5 years ago

Is it expecting little-endian, or a conversion to big-endian is required on the library side?

Expects and returns little-endian, no further conversion required on the library side.