search

Nitrokey / libnitrokey

Communicate with Nitrokey devices in a clean and easy manner
https://nitrokey.com/
GNU Lesser General Public License v3.0
65 stars 34 forks source link

Identify Librem Key, behaving like Nitrokey Pro device #163

Closed AmitAronovitch closed 4 years ago

AmitAronovitch commented 5 years ago

resolves #162

AmitAronovitch commented 5 years ago

Note that the CI tests fail on master as well - I think this is unrelated to the PR

szszszsz commented 5 years ago

Hi @AmitAronovitch !

Thank you for the PR! Looks good! Will run the full tests locally with two other devices, fix the CI to confirm (some unrelated issue indeed), and then merge.

szszszsz commented 4 years ago

Merged with changes, as suggested in:

No symbols deleted to keep the binary compatibility.

worldofgeese commented 4 years ago

@szszszsz Is there a timeline for a new release of the Nitrokey App that rolls in these and other changes?

allnamesaretakeningithub commented 4 years ago

Yes I would be interested about knowing the timeline, if it is public.

szszszsz commented 4 years ago

Hi! There is no specific timeline yet, but I estimate it will take a month since work starts, probably next week. There should be a couple of beta releases, with AppImage and Snap builds to use outside of the regular OS release/update cycle.

allnamesaretakeningithub commented 4 years ago

thank you!

allnamesaretakeningithub commented 4 years ago

thank you!