Nivrad00 / social-landmines

MIT License
0 stars 0 forks source link

Using rollback sometimes causes a crash #5

Closed Nivrad00 closed 3 years ago

Nivrad00 commented 3 years ago

Possible triggered by rolling back and then making a new choice?

Nivrad00 commented 3 years ago

I think I figured out the cause (or one of the causes). If you rollback when presented a choice, it doesn't properly clear all the state associated with waiting for a choice. Then, if you rollback all the way to a different choice, the system gets confused bc it's still waiting for the original choice to be made... or something. This can cause issues such as a blank dialog box showing up or having to click twice before the choice goes through.

This may or may not be the same issue that's causing the crash, but it seems related.

Nivrad00 commented 3 years ago

Couldn't replicate - could have something to do with the complexity of the "beans" test script we were using, or maybe it was fixed by another change. Going to close for now