search

NixOS / nixops

NixOps is a tool for deploying to NixOS machines in a network or cloud.
https://nixos.org/nixops
GNU Lesser General Public License v3.0
1.87k stars 364 forks source link

Fix legacy 1.7 build [with potential downsides] #1401

Closed allgreed closed 3 years ago

allgreed commented 4 years ago

There was some incompatibilities that prevented the build from completing, I've patched them to make it work, commenting out a few lines of code (marked in README) - this is likely break GCE and Azure potentially, but I haven't tested. Works on existing (pre 2.0) nixops project out of the box (with DigitalOcean as the cloud of choice).

But I guess that partially working legacy nixops is better than one that cannot be built

allgreed commented 4 years ago

@cole-h I've changed the loaOf as per your suggestion (in the whole project), however then the entire thing breaks:

error: The option `fileSystems.<name>.device' defined in `[ path to repo ]/nixops/nix/gce.nix' does not exist.

also: any idea what to put instead of type = types.listOf types.string;? This one seems to be deprecated as well

celestefox commented 4 years ago

There's not a one-size-fits all replacement, https://github.com/NixOS/nixpkgs/pull/66346 has a summary of the options.

allgreed commented 4 years ago

@mystfox thanks for the suggestions, all done [and Travis is now passing <3]. Previously I was just trying to see if it will work ;)

Unfortunately I have no idea how to fix the fileSystems issue with azure and gce

adisbladis commented 3 years ago

Closing this as it's very likely stale and 1.7 is not seeing any development.

Feel free to reopen if it's still relevant.