search

NixOS / nixops

NixOps is a tool for deploying to NixOS machines in a network or cloud.
https://nixos.org/nixops
GNU Lesser General Public License v3.0
1.86k stars 365 forks source link

Switch from fixMergeModules to evalModules #1506

Closed talyz closed 2 years ago

talyz commented 2 years ago

fixMergeModules is deprecated and using it produces deprecation warning messages in newer revisions of nixpkgs. Since it's implemented as a simple wrapper around evalModules, let's just use evalModules instead and set the module arguments through config._module.args.

Fixes #1507

roberth commented 2 years ago

For the purpose of bisectability, could you split this into

  1. a commit that inlines the fixMergeModules definition and avoids the deprecated args. This still includes moduleArgs._module.check = false. That should make it purely refactoring.
  2. a commit that removes moduleArgs._module.check = false, which is not a pure refactoring, but a change in behavior that is probably good.
talyz commented 2 years ago

Done!

roberth commented 2 years ago

Thank you!