search

NixOS / nixos-hardware

A collection of NixOS modules covering hardware quirks.
Creative Commons Zero v1.0 Universal
2.07k stars 641 forks source link

XPS 13 9310 question #243

Open seqizz opened 3 years ago

seqizz commented 3 years ago

Hi, I saw the related config but I didn't need any of those when I use boot.kernelPackages = pkgs.linuxPackages_latest;. So my question is, is this the same hardware? If not I'd also like to add config for this model, maybe suffixing with "2-in-1". My result is:

~> sudo dmidecode| grep -i xps
        Product Name: XPS 13 9310 2-in-1

Maybe @mitchmindtree ?

Mic92 commented 3 years ago

Is it possible that these patches became upstream in one way or the other? Maybe we can drop the whole custom kernel thing.

Mic92 commented 3 years ago

Maybe you and @mitchmindtree could both post the wifi chipset that was used. Most patches seems to be related to this.

seqizz commented 3 years ago

Aaah makes sense. Looks like there are 2 different variants of wifi on this model. Mine is indeed AX201:

00:14.3 Network controller: Intel Corporation Wi-Fi 6 AX201 (rev 20)

Since there is no "if" we can use, should I send my version with -ax201 suffix?

mitchmindtree commented 3 years ago

@seqizz we might be better off creating a module option (see here for info about module structure) for specifying either one in the configuration.

seqizz commented 3 years ago

Honestly I don't have much experience with modules, will check it out. Hopefully there is an example in the repo already.

Mic92 commented 3 years ago

I would add an option to enable AX500 support and deprecate it once mainline supports this wifi chipset.

This is an example for a module option:

https://github.com/NixOS/nixpkgs/blob/d9f9a4a9760ef3cf3df63771cebefacd1b0178b4/nixos/modules/hardware/keyboard/zsa.nix#L23