NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.38k stars 14.33k forks source link

Patch chromium to search for extensions from $CHROMIUM_EXTENSION_DIRECTORY instead of /usr/share/chromium/extensions #187899

Open the-argus opened 2 years ago

the-argus commented 2 years ago

See title. This would allow for declarative installation of chromium extensions. This is a patch stolen from guix, find it here.

I will make a PR where I will only add the patch to the chromium derivation. So if a nix user wants to declaratively install extensions, they'll have to make a wrapper drv and provide it with the CHROMIUM_EXTENSION_DIRECTORY variable.

the-argus commented 2 years ago

Okay great, everything works. I spent a lot of time typing CHROMIUM_EXTENSIONS_DIRECTORY instead of the correct CHROMIUM_EXTENSION_DIRECTORY but eventually realized everything was good. Plus it only took 6h50m22s to build!