24.11: jetbrains.plugins.addPlugins no longer finds github-copilot

lostmsu commented 1 week ago

Describe the bug

I am unable to add official GitHub Copilot plugin to Rider (haven't tried with other JetBrains products):

error: Could not resolve plugin github-copilot

Steps To Reproduce

Steps to reproduce the behavior:

Config

nixpkgs.config.allowUnfreePredicate = pkg:
builtins.elem (lib.getName pkg) [
  "rider"
  "rider-with-plugins"
];

environment.systemPackages = with pkgs; [
(jetbrains.plugins.addPlugins jetbrains.rider ["github-copilot" "nixidea"])
...
];

Expected behavior

Configuration builds. Rider has GitHub Copilot plugin

Screenshots

Additional context

I believe this is a regression since 24.05

Metadata

system: "x86_64-linux"
host os: Linux 6.6.60, NixOS, 24.11 (Vicuna), 24.11beta708443.057f63b6dc1a
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.24.10
channels(root): "home-manager, nixos-24.11"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Notify maintainers

@Followin @wegank

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

TheToto commented 1 week ago

The copilot plugin name is now github-copilot-intellij.

Here https://github.com/NixOS/nixpkgs/pull/355566/files#diff-07ece957f27494ff3a0079d3239e0ecd8f99335f468ff3c57941d61185666cb4R617

Kek5chen commented 1 week ago

See comment in #355566

JohnRTitor commented 1 week ago

Should be fixed with https://github.com/NixOS/nixpkgs/pull/355697 (they seemed to change it to what it was?)

But I am afraid if upstream changes the plugin name like this, we can't keep up announcing these breaking changes, since this is all automated

NixOS / nixpkgs