NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
16.96k stars 13.33k forks source link

leo-editor missing run time dependency #89534

Open RamKromberg opened 4 years ago

RamKromberg commented 4 years ago

if you run leo it will give you a warning about missing the meta package. I don't use leo and only tested it in home-manager but a preamble like this should work:


let

Meta = buildPythonPackage rec {
  pname = "Meta";
  version = "1.0.2";

  src = fetchPypi {
    pname = "meta";
    inherit version;
    sha256 = "0xh69dkvy5x5f9h2qig5i57f45hf78zaqk7g6r4f029c457x5frm";
  };

  # TODO tests
  # buildInputs = with python3.pkgs; [ networkx ];
  checkPhase = "true";

  meta = {
    description = "Pure Python module containing a framework to manipulate and analyze python abstract syntax trees and bytecode";
    homepage = http://srossross.github.io/Meta/;
    license = lib.licenses.bsd;
  };
};

in

...and then propagate it into propagatedBuildInputs.

@r-ryantm @leonardoce

p.s.

screenshot: https://gist.github.com/RamKromberg/262f6ab4ac54e504d697c4235f9b65e9

it's on the bottom left textbox stating:

livecode.py: can not import meta
you can install meta with 'pip install meta'
stale[bot] commented 3 years ago

I marked this as stale due to inactivity. → More info

patka-123 commented 8 months ago

Hello @RamKromberg :wave:

I have tried to reproduce this issue but I don't get a warning about a missing package anymore. Does this mean that this is resolved? If so, would you be able to close this issue?

(I'm going through issues marked as stale to see what can be resolved. If this is still an issue then don't mind me).

RamKromberg commented 8 months ago

@patka-123 It most likely a silent failure as it's still listed as a setup.py dependency for the livecode.py plugin and it's wrapped in a try..except...: https://github.com/leo-editor/leo-editor/commit/c45e2d97a03e8a884d2e2e7519449e8f3f94d2cb https://github.com/leo-editor/leo-editor/blob/devel/setup.py#L43 https://github.com/leo-editor/leo-editor/blob/devel/leo/plugins/livecode.py#L17 https://github.com/leo-editor/leo-editor/blob/devel/leo/plugins/livecode.py#L39C1-L40C71

mind you, I don't use leo.