search

NoBrainerORM / nobrainer

Ruby ORM for RethinkDB
http://nobrainer.io/
Other
387 stars 49 forks source link

Add support for partial compound index queries (closes #272) #278

Closed CodeMonkeySteve closed 2 years ago

zedtux commented 3 years ago

Kind a strange that Travis has not run ...

CodeMonkeySteve commented 3 years ago

Refactored to make compound-partial the strategy of last resort (to preserve backward compatibility)

zedtux commented 2 years ago

Could you please rebase your PR so that this PR is up-to-date and it will trigger the build now the CI is working again?

zedtux commented 2 years ago

I've finally migrated the project to Github Actions and the build is green on master.

I've already asked you to rebase your branch, and I'm sorry to ask you this again, but can you please rebase again your branch please ?

CodeMonkeySteve commented 2 years ago

Rebased, with a small fix for Ruby2.2/Rails4.

zedtux commented 2 years ago

Sorry for the bad GH Actions configuration. It's now fixed (tested with my old fork of this project). Can you please rebase again ? It should trigger the build.

zedtux commented 2 years ago

LGTM thank you ! I think an update of the "Indexes" documentation page would be great in order to explain this index support extension. Could be just a sentence or more if you feel inspired :wink:

CodeMonkeySteve commented 2 years ago

Happy to add docs, now that I'm a reluctant expert in partial indexes. Is this the page to add that? https://github.com/NoBrainerORM/nobrainer.io/blob/master/docs/indexes.md

zedtux commented 2 years ago

Yes, that's the right page.