Closed mattarau closed 3 years ago
Hey @mdentinho,
As you can see, there's a conflict here. It's to do with the highlight.js
reference. On your fork it's referencing 9.3.0
, but on our master it's referencing 9.12.0
.
If you could add that change to this PR, I'll review it again.
Thanks very much for contributing!
What does this PR cover?
It fixes a wrong variable name for
override_code_highlight_bg
in theindex.html
file.How can this be tested?
code_highlight_theme
defined (the defaultgithub
will work).override_code_highlight_bg
to a dark color (i.e.#090B0C
).Screenshots / Screencast
After following the above steps (but using
vs
ascode_highlight_theme
):Observation
I haven‘t created an issue before sending this PR (because of the simplicity of the change). To reproduce the error, you can follow the steps above and check that the dark background is not applied:
Reviewers
Review 1
Review 2 (optional)
By adding a +1 you are confirming you have...