search

NodeGuy / server-date

Make the server's clock available in the browser.
http://www.nodeguy.com/serverdate/
Mozilla Public License 2.0
193 stars 52 forks source link

Removed Node & PHP Dependency #25

Closed broomstick73 closed 8 years ago

broomstick73 commented 9 years ago

Changed ServerDate.js to use HTTP Response Header ("Date") for the server date and initialize with client date. Changed example.html file to reference the javascript file instead of a server-side dynamically generated script file.

NodeGuy commented 9 years ago

Please push your new commits to the pull request.

Also please modify the README file to reflect your changes.

broomstick73 commented 9 years ago

Thanks for being so patient with me. This is the first time I've used Github to contribute to anything and the first time I've used Git. I think the new commits are part of the pull request now.

I got rid of the PHP & NodeJS parts, should I get rid of the "Requirements" header? I'm not sure if it goes with the "tested with browsers.." bit or not.

broomstick73 commented 9 years ago

Does the node_modules folder need to hang around or does that go away? I didn't know if that was part of the Node Example or the Jasmine Tests or something else.

James C. james.conley@gmail.com

On Tue, Sep 29, 2015 at 7:12 PM, David Braun notifications@github.com wrote:

Please push your new commits to the pull request.

Also please modify the README file to reflect your changes.

— Reply to this email directly or view it on GitHub https://github.com/NodeGuy/ServerDate/pull/25#issuecomment-144217490.

NodeGuy commented 8 years ago

Aside from the typo, everything's looking great and we're ready to merge.

broomstick73 commented 8 years ago

Should be done & committed.

James C. james.conley@gmail.com

On Sat, Oct 3, 2015 at 8:01 PM, David Braun notifications@github.com wrote:

Aside from the typo, everything's looking great and we're ready to merge.

— Reply to this email directly or view it on GitHub https://github.com/NodeGuy/ServerDate/pull/25#issuecomment-145300030.

NodeGuy commented 8 years ago

Thanks for your contribution!

broomstick73 commented 8 years ago

Thanks for your patience!

James C. james.conley@gmail.com

On Mon, Oct 5, 2015 at 12:48 PM, David Braun notifications@github.com wrote:

Thanks for your contribution!

— Reply to this email directly or view it on GitHub https://github.com/NodeGuy/ServerDate/pull/25#issuecomment-145595918.