Nodeclipse / nodeclipse

Nodeclipse-1 : Eclipse plugin for Node.js, PhantomJS development (Nodeclipse core plugin); Maven and Gradle (with Android) plugins
https://nodeclipse.github.io/
158 stars 78 forks source link

Support black background color schemes. #15

Closed paulvi closed 11 years ago

paulvi commented 11 years ago

Support black background color schemes.

This is actually for Aptana Studio users, where default background is black.

black-background-color-schemes

paulvi commented 11 years ago

Solution may be TOP10 Marketplace download Eclipse Color Theme. Just change theme to Roboticket or other white background. Window->Preferences->General->Appearance->Color Theme

https://github.com/Nodeclipse/eclipse-node-ide/blob/master/Hints.md#aptana-studio

paulvi commented 11 years ago

I guess this is the only class to be changed. NodeCodeScanner.java

paulvi commented 11 years ago

@tomotaro1065 I was trying 0.4 on Atana 3.3.1.201212171919 (see #46 ), and discovered that this issue #15 is somehow fixed. Although pull request #39 from @gurok was not merged.

15

What is happening? Is it miracle? Or just because we changed Nodeclipse Editor to be based on JSDT Editor?

tomotaro1065 commented 11 years ago

Yes. That is due to NodeEditor based on JSDT Editor.

2013/5/20 Paul Verest notifications@github.com

@tomotaro1065 https://github.com/tomotaro1065 I was trying 0.4 on Atana 3.3.1.201212171919 (see #46https://github.com/Nodeclipse/nodeclipse-1/issues/46), and discovered that this issue

15 https://github.com/Nodeclipse/nodeclipse-1/issues/15 is somehow

fixed.

[image: 15]https://f.cloud.github.com/assets/1614482/528321/c717a8a4-c124-11e2-8b11-ee099bbfe061.png

Though pull request #39https://github.com/Nodeclipse/nodeclipse-1/issues/39from @gurok https://github.com/gurok was not merged. What is happening? Is it miracle? Or just because we changed Nodeclipse Editor to be based on JSDT Editor?

— Reply to this email directly or view it on GitHubhttps://github.com/Nodeclipse/nodeclipse-1/issues/15#issuecomment-18136565 .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

paulvi commented 11 years ago

One more issue closed with 0.4 release

paulvi commented 11 years ago

@tomotaro1065 However Chromium JS Editor, used during debugging still has the issue. Chromium JS Editor also doesn't have Outline #11

tomotaro1065 commented 11 years ago

Hmm... But it's an issue for chromedevtools, not for nodeclipse. In the future, we will not use chromedevtools. So I do not want to spend too much effort for that. I want to give priority to enhance the code assist where related node.js.

paulvi commented 11 years ago

That is fine. But we still have colors issue in Aptana. So the issue is opened (I don't like to create new issue for Chromium in debugging mode).

paulvi commented 11 years ago

I don't like to create new issue

But I did, to have 0.4 formally closed.