Nodeclipse / nodeclipse

Nodeclipse-1 : Eclipse plugin for Node.js, PhantomJS development (Nodeclipse core plugin); Maven and Gradle (with Android) plugins
https://nodeclipse.github.io/
158 stars 78 forks source link

Bundle Express as jar, was: Install Express automatically #17

Open paulvi opened 11 years ago

paulvi commented 11 years ago

If failing to launch express project creation, run npm install -g express process from inside Eclipse.

tomotaro1065 commented 11 years ago

The global installation of Express automatically is difficult in relation to authority. So we are going to bundle it with Nodeclipse. Nodeclipse uses bundled Express only if Nodelipse user don't install Express. I decided to bundle coffee-script also as well.

paulvi commented 11 years ago

It should be additional .jar features, as it will eat some memory, when plugin is loaded.

On 08.06.2013 16:08, Tomoyuki Inagaki wrote:

The global installation of Express automatically is difficult in relation to authority. So we are going to bundle it with Nodeclipse. Nodeclipse uses bundled Express only if Nodelipse user don't install Express. I decided to bundle coffee-script also as well.

— Reply to this email directly or view it on GitHub https://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-19145061.

tomotaro1065 commented 11 years ago

On Github, jar files of bundles are divided from jar of Nodeclipse.

paulvi commented 11 years ago

What do you mean? Please extend your idea.

I think coffeescript should be in external jar. I played a bit with running JavaScrtipt from within JVM, but have not succeeded so far. Take a look at https://github.com/PaulVI/nodejar-coffeescript

I think the most elegant solution will be calling npm-installed coffee-script from Java. Yes it will require user to preinstall. But for the 1st version it is great. Moreover people who need CoffeeScript for Node, are very like have installed with npm.

UPDATE: oops, express not CoffeeScript. Still I think the handling should be the same. And even if we bundle node modules inside we should check if newer version exists outside.

tomotaro1065 commented 11 years ago

Yes, Express and Coffee-script are moved to external jar files.

I have tried install coffee-script via npm from Nodeclipse's code. But on linux, It must execute as administrator, so I gave up. Instead of it, I thought it works well to bundle them with Nodeclipse.

paulvi commented 11 years ago

well, we can also prepare script for users, that will install express, coffee-script and possibly other required Node.js libraries as well. As long as it solves user task it is good solution.

tomotaro1065 commented 11 years ago

Do you mean that we create batch files that contains "npm -g install express" for instance? If we cannot install them automatically, I think there is no need to be up there.

paulvi commented 11 years ago

Yes, that was an idea we maybe will never use.

On 10.08.2013 14:48, Tomoyuki Inagaki wrote:

Do you mean that we create batch files that contains "npm -g install express" for instance? If we cannot install them automatically, I think there is no need to be up there.

— Reply to this email directly or view it on GitHub https://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-22435209.

tomotaro1065 commented 11 years ago

We cannot install any plug-in of Node.js such as Express, but we can bundle them. And I'm ready for it on Github repo. After all, do we bundle them with Nodeclipse or not?

paulvi commented 11 years ago

1) Even if we bundle, there must be option for that

2) Those modules should be external. Then more developers can use them in other projects, update versions, add new etc

Please check https://github.com/nodejar as possible home for the project.

Maven is better as we can redistribute jar on Maven Central.

tomotaro1065 commented 11 years ago

Yes, User can select install them or not. On github repo, they are already made as external jar.

2013/8/18 Paul Verest notifications@github.com

1) Even if we bundle, there must be option for that

  • [v] Use bundled Node.js modules

2) Those modules should be external. Then more developers can use them in other projects, update versions, add new etc

Please check https://github.com/nodejar as possible home for the project.

— Reply to this email directly or view it on GitHubhttps://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-22827869 .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

paulvi commented 11 years ago

What about if Express 3.1 is installed with Nodeclipse and Express 3.2 is released.

Does user have option to use external express ?

tomotaro1065 commented 11 years ago

If the user installed Express via npm by themself, Nodeclipse will be used it even if they selected to install Express bundle with Nodeclipse.

2013/8/19 Paul Verest notifications@github.com

What about if Express 3.1 is installed with Nodeclipse and Express 3.2 is released.

Does user have option to use external express ?

— Reply to this email directly or view it on GitHubhttps://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-22877068 .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

paulvi commented 11 years ago

OK. If the Express path is configured, then external express is used.

Is this logic right?

On 19.08.2013 22:54, Tomoyuki Inagaki wrote:

If the user installed Express via npm by themself, Nodeclipse will be used it even if they selected to install Express bundle with Nodeclipse.

2013/8/19 Paul Verest notifications@github.com

What about if Express 3.1 is installed with Nodeclipse and Express 3.2 is released.

Does user have option to use external express ?

— Reply to this email directly or view it on GitHubhttps://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-22877068 .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

— Reply to this email directly or view it on GitHub https://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-22877747.

tomotaro1065 commented 11 years ago

To be exactly, the external Express is used, if the user install Express manually.

2013/8/20 Paul Verest notifications@github.com

OK. If the Express path is configured, then external express is used.

Is this logic right?

On 19.08.2013 22:54, Tomoyuki Inagaki wrote:

If the user installed Express via npm by themself, Nodeclipse will be used it even if they selected to install Express bundle with Nodeclipse.

2013/8/19 Paul Verest notifications@github.com

What about if Express 3.1 is installed with Nodeclipse and Express 3.2 is released.

Does user have option to use external express ?

— Reply to this email directly or view it on GitHub< https://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-22877068>

.

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

— Reply to this email directly or view it on GitHub < https://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-22877747>.

— Reply to this email directly or view it on GitHubhttps://github.com/Nodeclipse/nodeclipse-1/issues/17#issuecomment-22879848 .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

paulvi commented 9 years ago

There is need to remove 2 jars for coffee and express as they are outdated and make build noisy