search

Nodeclipse / nodeclipse

Nodeclipse-1 : Eclipse plugin for Node.js, PhantomJS development (Nodeclipse core plugin); Maven and Gradle (with Android) plugins
https://nodeclipse.github.io/
158 stars 78 forks source link

#40 Maven/tycho build passes (rename 2 chromium features: add .feature) #64

Closed paulvi closed 11 years ago

paulvi commented 11 years ago

@tomotaro1065 Take a look. Merge if OK

tomotaro1065 commented 11 years ago

This pullrequest is rejected.

paulvi commented 11 years ago

The tycho build can't go as 2 IS for features and plugins are the same. Either features or plugins must be renamed.

tomotaro1065 commented 11 years ago

Have you done testing of installing and behavior of Nodeclipse?

2013/8/24 Paul Verest notifications@github.com

The tycho build can't go as 2 IS for features and plugins are the same. Either features or plugins must be renamed.

— Reply to this email directly or view it on GitHubhttps://github.com/Nodeclipse/nodeclipse-1/pull/64#issuecomment-23203919 .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

paulvi commented 11 years ago

That why there is this PR: what should be changed: IDs for 2 plugins or IDs for 2 features? But it can't be as it is now, as feature & plugin use the same ID in 2 cases.

I am doing testing in my Eclipse now.

On 24.08.2013 14:29, Tomoyuki Inagaki wrote:

Have you done testing of installing and behavior of Nodeclipse?

2013/8/24 Paul Verest notifications@github.com

The tycho build can't go as 2 IS for features and plugins are the same. Either features or plugins must be renamed.

— Reply to this email directly or view it on GitHubhttps://github.com/Nodeclipse/nodeclipse-1/pull/64#issuecomment-23203919 .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

— Reply to this email directly or view it on GitHub https://github.com/Nodeclipse/nodeclipse-1/pull/64#issuecomment-23203974.

tomotaro1065 commented 11 years ago

Hi all,

I changed package of coffeescript bundle from org.nodeclipse.bundle.coffee_script to org.nodeclipse.bundle.coffee. Also changed package of feeature. Because that didn't work on Mac OS X.

Staging site was updated. You can download testing version of 0.5 from following url.

http://www.tomotaro1065.com/nodeclipse/staging/ We will release v0.5 next weekend. Is that OK?

2013/8/24 Paul Verest notifications@github.com

That why there is this PR: what should be changed: IDs for 2 plugins or IDs for 2 features? But it can't be as it is now, as feature & plugin use the same ID in 2 cases.

I am doing testing in my Eclipse now.

On 24.08.2013 14:29, Tomoyuki Inagaki wrote:

Have you done testing of installing and behavior of Nodeclipse?

2013/8/24 Paul Verest notifications@github.com

The tycho build can't go as 2 IS for features and plugins are the same. Either features or plugins must be renamed.

— Reply to this email directly or view it on GitHub< https://github.com/Nodeclipse/nodeclipse-1/pull/64#issuecomment-23203919> .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

— Reply to this email directly or view it on GitHub < https://github.com/Nodeclipse/nodeclipse-1/pull/64#issuecomment-23203974>.

— Reply to this email directly or view it on GitHubhttps://github.com/Nodeclipse/nodeclipse-1/pull/64#issuecomment-23205572 .

http://www.nodeclipse.org/

blog: http://d.hatena.ne.jp/tomotaro1065/ twitter: @tomotaro1065

paulvi commented 11 years ago

It was not so nice of you to rename folder before my changes are merged.

Yes, whatever happens we are to release 0.5 next week-end

tomotaro1065 commented 11 years ago

I'm sorry for changing those package. Please change your changes.

OK. I will release 0.5 this week-end.

By the way, have your testing been completed?

paulvi commented 11 years ago

I have installed 0.5 built with maven on my PC. Works OK. The #40 is closed.

Let's release 0.5 with manual build, then in 0.6 see if we can fully migrate to maven.