Nordgaren / Elden-Ring-Debug-Tool

Debug tool for Elden Ring modding
GNU General Public License v3.0
134 stars 21 forks source link

Missing/incorrectly categorized items #82

Open Umgak opened 4 months ago

Umgak commented 4 months ago

The following items are miscategorized: Igon's Harpoon (Items\DLC\DLCWeapons\DLCMeleeWeapons.txt:58, should be Items\DLC\DLCWeapons\DLCAmmo.txt:3) Perfumer's Talisman (Items\DLC\DLCTalismans.txt:1, this item is not from the DLC and is already present in Items\Talismans.txt:65)

The following items are missing: Items\DLC\DLCWeapons\DLCAmmo.txt (DLCAmmo is also out of order)

51500000 Igon's Harpoon

Items\DLC\DLCWeapons\DLCMeleeWeapons.txt

1510000 Fire Knight's Shortsword
4520000 Fire Knight's Greatsword
12530000 Bloodfiend's Arm
16540000 Bloodfiend's Fork

Items\DLC\DLCWeapons\DLCShields.txt

21550000 Shield of Night

Items\DLC\DLCWeapons\DLCSpellTools.txt

34510000 Fire Knight's Seal

Also, Items\DLC\DLCMagic.txt is missing categories, and several categories are formatted as [ID] - [Name] instead of the standard [ID] [Name] format. I have not reviewed Goods categories or Armor.

Here are the resources files with my changes included. Resources.zip

Nordgaren commented 4 months ago

Hmm. I wonder why these weren't found in the script. I'll have to take a look at it. The grouping of stuff is done manually though, so that could be why things got placed in the wrong file.

WDYM DLCMagic is missing categories? You mean missing entries?

Thanks for the bug report!

Umgak commented 4 months ago

WDYM DLCMagic is missing categories? You mean missing entries?

In the vanilla Magic.txt, all spell names are preceded by their spell type, either [Sorcery] or [Incantation]. This wasn't carried over to DLC spells, so I added them for consistency. All of the spells are there (unless there's some super secret Miyazaki ARG or something, but that's unlikely) with their correct IDs, I just prefixed them.