Nordstrom / xrpc

Simple, production ready Java API server built on top of functional composition.
Apache License 2.0
17 stars 17 forks source link

context groups not URL decoded #44

Open patrickdent opened 6 years ago

patrickdent commented 6 years ago
 Handler personHandler =
        context -> {
          Person p = new Person(context.variable("person"));
          people.add(p);

          return Recipes.newResponseOk("");
        };

from Example.java

if your url is something like /people/Samwise%20Gamgee, context.variable("person") will equal Samwise%20Gamgee. It may be more friendly if xrpc does the Url decoding.

patrickdent commented 6 years ago

After revisiting this - I discovered that the original issue, as reported, was also fixed by https://github.com/Nordstrom/xrpc/pull/54 (this was a result of the http2 onHeadersRead not using XUrl to get the path).

However, it seems that the Query Strings aren't being decoded. This is worth addressing, I think.