search

Norkart / Leaflet-MiniMap

A minimap control plugin for Leaflet
BSD 2-Clause "Simplified" License
395 stars 125 forks source link

feat: add minimized option #104

Closed deeg closed 8 years ago

deeg commented 8 years ago

Great library, thanks!

Wanted to allow the minimap to start in a minimized state, without having to use private methods to close it which causes a flicker if you look close.

robpvn commented 8 years ago

Looks good to me!

deeg commented 8 years ago

Thanks for the quick merge!

Would you consider releasing a 3.0.1 release for bower at some point in the near future?

robpvn commented 8 years ago

There, that's about as pushed as I can make it. For some reason the Bower version badge hasn't updated for me yet, I guess it might be a cache issue.

deeg commented 8 years ago

Thanks again!

seyfro commented 8 years ago

Hi guys,

thanks a lot for adding minimized as option - unfortunately this does not seem to work on my site. I searched for any mistake I could have made, but couldnt find any, so your help would really be appreciated! See demo map at https://www.mapsmarker.com/dev/pro/2016/02/25/siteoriginyoast-issue/

I use the latest codebase and added the option minimized: true to the constructor: var miniMap_layermap_6 = new L.Control.MiniMap(osm_mapnik_minimap, {position: 'bottomright', width: 150, height: 150, collapsedWidth: 19, collapsedHeight: 19, zoomLevelOffset: -5, zoomAnimation: false, toggleDisplay: true, autoToggleDisplay: false, minimized: true}).addTo(layermap_6); Anyway this does not seem to have any effect. So I tried changing the default value on line 30 to "minimized: true," - didnt have any effects either.

It also seems that the minimap now needs 2 clicks before it is minimized - the first click does not have any effect.

Any help here would be appreciated! best,

Robert

robpvn commented 8 years ago

@deeg , do you want to have a go at debugging this since you're the most familiar with the implementation of it? From a quick glance it looks like setting this._minimized on line 86 intereferes with _setDisplay so that things get cancelled out.

I'll make this a new bug since we've already released this.