NormanTUD / JupyterKernels

0 stars 0 forks source link

kernel specific modules not reflected in start file #2

Closed elwer closed 3 weeks ago

elwer commented 1 month ago

Kernel specific modules in the form:

tensorflow": {
      "name": "TensorFlow (Machine Learning)",
      "modules_load": {
              "alpha": "TensorFlow/2.11.0-CUDA-11.7.0",
              "romeo": "TensorFlow/2.11.0-CUDA-11.7.0",
              "barnard": "TensorFlow/2.9.1"
      },

are not reflected in the start-kernel.sh file

elwer commented 1 month ago

Just have seen: there is one possible parameter called "module_load" (e.g. "module_load": ["PyTorch/1.13.1"]), while the above one is "modules_load". Is that intended or should they be unified?

NormanTUD commented 3 weeks ago

The first issue should be solved, the 2nd one is intentional. modules_load allows you to load different modules, depending on the cluster host. The module_load does not allow that, it uses the modules listed there indiscriminately of the cluster.

Hopefully that solves this.

elwer commented 3 weeks ago

Now, in case we don't have any particular modules defined via module_load or the new module_load_cluster parameter, it adds "null" to the list of modules. Can we have a check in advance whether the parameters are defined and if not, skip it? "null" should be avoided.

NormanTUD commented 1 week ago

Please see if its fixed in e1097b399adefad73a98055d5c9291c3b6063099