NorskRegnesentral / shapr

Explaining the output of machine learning models with more accurately estimated Shapley values
https://norskregnesentral.github.io/shapr/
Other
141 stars 33 forks source link

Fix bug in vaeac related to updating of factor labels #382

Closed LHBO closed 6 months ago

LHBO commented 6 months ago

In this pull request, we fix a bug in the VAEAC approach that could occur for specific batches of combinations. The bug happened when vaeac converted the imputed integers back to the original factors, and not all possible levels were present. We have fixed the bug by specifying levels = ... in the call to the factor(...) function. This bug never occurred when n_batches = 1 and was not likely to occur for low values of n_batches. It was more likely to occur for rare levels.