search

Not-Diamond / notdiamond-python

Not Diamond Python SDK
54 stars 8 forks source link

Using pydantic.v1 validator for langchain compat. #26

Closed acompa closed 2 months ago

acompa commented 2 months ago

Feel free to merge once these tests pass.

r0ymanesco commented 2 months ago

Is this needed so that we can support python 3.8 and 3.9?

acompa commented 2 months ago

Is this needed so that we can support python 3.8 and 3.9?

Correct, per ENG-1092

r0ymanesco commented 2 months ago

Is this needed so that we can support python 3.8 and 3.9?

Correct, per ENG-1092

Ok makes sense. Approving but as you mentioned in the ticket, perhaps hold off until they confirm we have to support those python versions?