NotNite / Linkpearl

An actually updated Mumble positional audio plugin for FINAL FANTASY XIV

3 stars 1 forks source link

Doesn't respect actual listening position #1

Closed NotNite closed 2 months ago

NotNite commented 1 year ago

Right now Linkpearl functions by using the direct position of the camera and player object. This means, for example, System Configuration > Sound Settings > Listening Position isn't respected.

This is an oversight (whoops) that I only realized after @s5bug asked me about it. Whoops!

There are two ways I can think of to solve this:

Fetch the Listening Position setting, calculate the difference between the camera and player object, and then scale it accordingly
- This'll work, and be easy for my bad at RE and bad at 3D math brain, but it might have weirdness in cutscenes
- Figure out the position and rotation in 3D space your ears are at in game and use that
- I don't know if this is A Thing in FFXIVClientStructs - will look after I press Submit new issue

NotNite commented 1 year ago

The relevant setting is SoundMicpos - I don't know what happened exactly but I know some settings thing happened with this patch and that makes me scared to touch game configs.

lostkagamine commented 1 year ago

is SoundMicpos a float between 1.0 and 0.0?

NotNite commented 1 year ago

Integer between 0 and 100, where 0 is directly on top of the camera and 100 is directly on top of the player.

I think(?) there was talk about a game config API in Dalamud sometime soon, so I'll hold back on investigating this until later.

lostkagamine commented 1 year ago

Delayed until Dalamud/ClientStructs update to un-break the game settings API.

NotNite commented 1 year ago

I hate GitHub so much

NotNite commented 1 year ago

Seems like after talking to people, while the API was talked about, it wasn't actually confirmed? Might be safe to work on now - gonna give it a shot.

NotNite commented 1 year ago

Got a hacky proof of concept here. I'll wait until Linkpearl gets accepted to add this, probably.

lostkagamine commented 1 year ago

Implemented in listening-pos/3ad6605f. Needs testing. I'll open a draft PR.

E: Draft PR up - #2

lostkagamine commented 1 year ago

2 has shown this functionality to work. Closing issue.

s5bug commented 1 year ago

2 says:

This pull request will respect the character listening position setting in Final Fantasy XIV's settings menu.

This is not complete behavior, as true listening position does not respect this setting in cutscenes and etc.

lostkagamine commented 1 year ago

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA