NotTobi / soundcloud-dl

Extension for downloading SoundCloud tracks
https://addons.mozilla.org/firefox/addon/soundcloud-dl
MIT License
97 stars 7 forks source link

Does not download original version #33

Open xeruf opened 3 years ago

xeruf commented 3 years ago

League of Legends have lots of enabled free downloads, I was hoping to bulk-download with this extension. But on the songs I tried, it does not download the original (a wav/flac) but an mp3: https://soundcloud.com/leagueoflegends/psyops-2020 https://soundcloud.com/leagueoflegends/sets/2014-world-championship

But thanks for your work on this already :)

NotTobi commented 3 years ago

Have you enabled the download of the original file in the settings? I believe it's off per default. If it's on and it doesn't work, I might look into it over the weekend. Cant promise anything though, am pretty swamped atm :/

xeruf commented 3 years ago

Thank you, this is great for downloading whole playlists, and the fact that it sets proper filenames is convenient too! It says "metadata might not be set", I am not sure how to interpret that. Will it not touch original files at all? Does it depend on the format? Will it override existing tags?

Totally feel you on being swamped though ;)

NotTobi commented 2 years ago

There could be a variety of different music formats the artists offers for download. We support setting metadata for mp3, m4a and wav. If another type is detected, the file itself will not be modified and only the filename might be changed depending on the add-on settings.

eggsgent commented 2 years ago

Hi, I have a similar issue. Sometimes the extension downloads 128kbps file, other times it downloads the 320kbps file from the same URL. Example URL: https://soundcloud.com/christopherlawrence/pharmacy-radio-071-w-guests-santiago-torelli-another-station?in=christopherlawrence/sets/rush-hour-radio