Notalib / LYT

m.e17.dk
GNU Lesser General Public License v3.0
10 stars 12 forks source link

playback-rate on iphone (IOS6) first takes effect on pause/play #470

Closed LDHgithub closed 10 years ago

LDHgithub commented 11 years ago

When you change the playbackrate on iphone it dosen´t cahnge before you press pause and then play again. If you change the setting while player is paused, it works correctly.

This can probably be solved by injecting a pause + play after the playbackrate has been set (on ratechange).

LDHgithub commented 11 years ago

ups..

simmoe commented 11 years ago

@LDHgithub The immediate shift to playbackrate works on iphone now. BUT not across sections - so if you open a fulltext book say bob dylan leksikon - and change playback rate while listening to a section, then the player shifts to next section - and the playback rate gore - unexpectedly - back to normal tempo. Looking in settings, PBR is still set to the one you chose..

mzedeler commented 11 years ago

This is now a problem on LYT-2, so I am reopening this issue.

mzedeler commented 11 years ago

This issue has been investigated by @KRW-nota and @katiakn using a specialized playback rate test here:

http://jsbin.com/arecoq/101/edit

The results are in, but I haven't had time to analyze them.

saebekassebil commented 10 years ago

@mzedeler: This should be fixed by above commit - I've tested on iOS7 device (an iPod) and on my Mac OSX and it should be ready for internal testing

simmoe commented 10 years ago

Cool, are you distributing a url to a test branch?

Sendt pr telefon

Den 24/10/2013 kl. 15.56 skrev Jakob Miland notifications@github.com:

@mzedeler: This should be fixed by above commit - I've tested on iOS7 device (an iPod) and on my Mac OSX and it should be ready for internal testing

— Reply to this email directly or view it on GitHub.

saebekassebil commented 10 years ago

@simmoe: This should hopefully work, on the local, Nota test server (testmstr01) in folder /playbackrate Sorry, try the release candidate here: http://test.m.e17.dk/lyt-2.0.0_011/

saebekassebil commented 10 years ago

Closing as fixed